| .. | .. |
|---|
| 20 | 20 | |
|---|
| 21 | 21 | ## MEDIUM (Improve before submission) |
|---|
| 22 | 22 | |
|---|
| 23 | | -- [ ] **M1: Subnet scan hammers 254 hosts** — Could trigger IDS. Detect subnet mask or cap range |
|---|
| 24 | | -- [ ] **M2: No loadMore debounce** — Scroll pagination fires repeatedly on iOS bounce. Add isLoading guard |
|---|
| 23 | +- [x] **M1: Subnet scan hammers 254 hosts** — Batched in groups of 20 with early exit *(fixed 2026-03-25)* |
|---|
| 24 | +- [x] **M2: No loadMore debounce** — Added isLoadingMore guard *(fixed 2026-03-25)* |
|---|
| 25 | 25 | - [ ] **M3: NavigateNotifier global singleton** — Mutable static, stale reference risk. Move to Riverpod provider |
|---|
| 26 | 26 | - [ ] **M4: Unbounded _seenSeqs set** — O(n log n) eviction. Use FIFO deque instead |
|---|
| 27 | 27 | - [ ] **M5: Screenshots bloat iCloud backup** — Store images as files, not base64 in JSON. Or exclude from backup |
|---|
| 28 | | -- [ ] **M6: Unused import** — `server_config.dart` import in chat_screen.dart suppressed with ignore comment |
|---|
| 29 | | -- [ ] **M7: Silent error swallowing** — ServerConfig _load() catches all exceptions silently. Add debugPrint |
|---|
| 28 | +- [x] **M6: Unused import** — Already removed *(fixed 2026-03-25)* |
|---|
| 29 | +- [x] **M7: Silent error swallowing** — Added debugPrint on config load failure *(fixed 2026-03-25)* |
|---|
| 30 | 30 | |
|---|
| 31 | 31 | ## LOW (Nice-to-haves) |
|---|
| 32 | 32 | |
|---|
| 33 | 33 | - [ ] **L1: PrivacyInfo.xcprivacy** — Required since 2024 for UserDefaults and FileTimestamp APIs |
|---|
| 34 | 34 | - [ ] **L2: Privacy policy URL** — Required for microphone/camera access apps |
|---|
| 35 | | -- [ ] **L3: Unused dependencies** — Remove `web_socket_channel` and `wakelock_plus` from pubspec.yaml |
|---|
| 35 | +- [x] **L3: Unused dependencies** — Removed web_socket_channel and wakelock_plus *(fixed 2026-03-25)* |
|---|
| 36 | 36 | - [x] **L4: Unnecessary _http._tcp** — Removed from NSBonjourServices *(fixed 2026-03-25)* |
|---|
| 37 | | -- [ ] **L5: Typing indicator timeout** — Can get stuck if typing_end missed during background. Auto-clear after 10s |
|---|
| 37 | +- [x] **L5: Typing indicator timeout** — Auto-clear after 10s *(fixed 2026-03-25)* |
|---|
| 38 | 38 | - [ ] **L6: Version number** — Default 1.0.0+1, set correctly before submission |
|---|
| 39 | 39 | - [ ] **L7: App icon** — Verify meets Apple guidelines (no alpha channel, correct sizes) |
|---|
| 40 | 40 | |
|---|
